This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Mon, 18 Jul 2011 10:37:54 +0100
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
Delivery-date: Mon, 18 Jul 2011 02:39:12 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=ka/Zv3uvWj2VQig17CN1LrDEQF8yfuVpXI9+hxLBB3g=; b=NvDcXlUdaeEQS4vsNYt36/P+nERqGnyKW4AKK8qQgPGbeyMBcB/36X5+WoeGtzs0QN yrr6ph9xTveTdMLuwUZiHOGpKZZBz/servAgNW4k39U7vpa0l7dHeW+8Dc64Rs1IBXF0 YlZpc18+92WkhDkKWW787VGFrUYsnmisg682U=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110718090416.GA23376@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxFLl5PQHUacVX0dUSWVNTMKBbuxg==
Thread-topic: [Xen-devel] Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var
User-agent: Microsoft-Entourage/
On 18/07/2011 10:04, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Sat, Jul 16, Keir Fraser wrote:
>> It's not like we have dodgy third-party drivers to worry about. Just fix the
>> code -- *which is in the tree!* -- that is making the bad calls! It was
>> correct to make this an assert/bug_on in the first place.
> trace_irq_mask() was the only function I found with a too large buffer.

Yes, the fix was the very next email I looked at. I've applied it. Thanks!

 -- Keir

> Olaf

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>