WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 4 of 4] Add a trace hypercall to allow tracing fr

To: George Dunlap <george.dunlap@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 4 of 4] Add a trace hypercall to allow tracing from dom0 or domU
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 15 Jul 2011 22:45:52 +0200
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Fri, 15 Jul 2011 13:46:50 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1310762756; l=1182; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=hE4uEDqCTV3wynf5cZodFUgxJxs=; b=H8quKkdsUtNJ8meKlue1Htrq6xmzwEddwuyjYdhJLk6N0oVeMl6WdK6qQsE5LGHuy2Z 6qX9T2+Iev5Z0Whn7knkuj+2/YWMfHG7p+d80mC0YYBQhb49NF85nok5UAVzHjO8/+aC/ 44pz8iFk+hj8PTJKSUXNWfmAAx/se936oJk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1310748546.448.106.camel@elijah>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1310744284@xxxxxxxxxxxx> <f72dcd1b8bbdc7487d58.1310744288@xxxxxxxxxxxx> <1310748546.448.106.camel@elijah>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21.rev5535 (2011-07-01)
On Fri, Jul 15, George Dunlap wrote:

> On Fri, 2011-07-15 at 16:38 +0100, Olaf Hering wrote:
> > @@ -65,6 +67,7 @@
> >  #define TRC_LOST_RECORDS        (TRC_GEN + 1)
> >  #define TRC_TRACE_WRAP_BUFFER  (TRC_GEN + 2)
> >  #define TRC_TRACE_CPU_CHANGE    (TRC_GEN + 3)
> > +#define TRC_TRACE_GUEST_HYPERCALL (TRC_GEN + 4)
> 
> Looks like perhaps a leftover from an earlier patch? :-)

Yes, thats true. It was a domctrl a few weeks ago.

> > diff -r 6e4aef7b5051 -r f72dcd1b8bbd xen/include/public/xen.h
> > --- a/xen/include/public/xen.h
> > +++ b/xen/include/public/xen.h
> > @@ -94,6 +94,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_pfn_t);
> >  #define __HYPERVISOR_kexec_op             37
> >  #define __HYPERVISOR_tmem_op              38
> >  #define __HYPERVISOR_xc_reserved_op       39 /* reserved for XenClient */
> > +#define __HYPERVISOR_xentrace_op          40
> 
> Seems unnecessary to make a whole hypercall just for this one thing, but
> I'll defer to Keir's judgement on that.  At very least, it should accept
> an "op" command, of which "trace" is just one, so that it's expandable
> in the future without breaking backwards compatibility.

One reason is that trace_hypercall() should not trace itself.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>