This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 2 of 4] xentrace: replace ASSERT with printk in __trace_var
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 18 Jul 2011 11:04:16 +0200
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
Delivery-date: Mon, 18 Jul 2011 02:06:05 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1310979860; l=337; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=C/b0VMnSAMZi8L7wrYxvIlQ3Xjk=; b=uvW2/zU6bt684LeeExaj/vOslqMl0VUULOuYzLEHrlP8rWuZPVPhOjXySQu5Nts/U8c Cx1OzqdGnd40pngpASnS8pPsk95YyLoetAYopDnZKfGypAxw0JnfMNqEq4kZm0e4yvdyJ uP6f8j2+RsZc45DWKv4hFeY2LPGkVce9C0s=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA470876.2F8DA%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1310747494.448.95.camel@elijah> <CA470876.2F8DA%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21.rev5535 (2011-07-01)
On Sat, Jul 16, Keir Fraser wrote:

> It's not like we have dodgy third-party drivers to worry about. Just fix the
> code -- *which is in the tree!* -- that is making the bad calls! It was
> correct to make this an assert/bug_on in the first place.

trace_irq_mask() was the only function I found with a too large buffer.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>