| 
         
xen-devel
[Xen-devel] [PATCH 08/14] x86/ticketlock: collapse a layer of	functions
 
| 
To:  | 
Peter Zijlstra <peterz@xxxxxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] [PATCH 08/14] x86/ticketlock: collapse a layer of	functions | 
 
| 
From:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Date:  | 
Tue, 16 Nov 2010 13:08:39 -0800 | 
 
| 
Cc:  | 
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>,	Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>,	Nick Piggin <npiggin@xxxxxxxxx>,	Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	Jan Beulich <JBeulich@xxxxxxxxxx>, Eric Dumazet <dada1@xxxxxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	Avi Kivity <avi@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>,	Américo Wang <xiyou.wangcong@xxxxxxxxx>,	Linux Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Tue, 16 Nov 2010 13:30:18 -0800 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
In-reply-to:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
References:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Now that the paravirtualization layer doesn't exist at the spinlock
level any more, we can collapse the __ticket_ functions into the arch_
functions.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
 arch/x86/include/asm/spinlock.h |   35 +++++------------------------------
 1 files changed, 5 insertions(+), 30 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index 8e379d3..cfa80b5 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -108,7 +108,7 @@ static __always_inline void __ticket_unlock_kick(struct 
arch_spinlock *lock, __t
                ____ticket_unlock_kick(lock, next);
 }
 
-static __always_inline void __ticket_spin_lock(struct arch_spinlock *lock)
+static __always_inline void arch_spin_lock(struct arch_spinlock *lock)
 {
        register struct __raw_tickets inc;
 
@@ -128,7 +128,7 @@ static __always_inline void __ticket_spin_lock(struct 
arch_spinlock *lock)
 out:   barrier();              /* make sure nothing creeps before the lock is 
taken */
 }
 
-static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
+static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
 {
        arch_spinlock_t old, new;
 
@@ -142,7 +142,7 @@ static __always_inline int 
__ticket_spin_trylock(arch_spinlock_t *lock)
        return cmpxchg(&lock->head_tail, old.head_tail, new.head_tail) == 
old.head_tail;
 }
 
-static __always_inline void __ticket_spin_unlock(arch_spinlock_t *lock)
+static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
 {
        __ticket_t next = lock->tickets.head + 1;
        __ticket_unlock_release(lock);
@@ -150,46 +150,21 @@ static __always_inline void 
__ticket_spin_unlock(arch_spinlock_t *lock)
        barrier();              /* prevent reordering into locked region */
 }
 
-static inline int __ticket_spin_is_locked(arch_spinlock_t *lock)
+static inline int arch_spin_is_locked(arch_spinlock_t *lock)
 {
        struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
 
        return !!(tmp.tail ^ tmp.head);
 }
 
-static inline int __ticket_spin_is_contended(arch_spinlock_t *lock)
+static inline int arch_spin_is_contended(arch_spinlock_t *lock)
 {
        struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
 
        return ((tmp.tail - tmp.head) & TICKET_MASK) > 1;
 }
-
-static inline int arch_spin_is_locked(arch_spinlock_t *lock)
-{
-       return __ticket_spin_is_locked(lock);
-}
-
-static inline int arch_spin_is_contended(arch_spinlock_t *lock)
-{
-       return __ticket_spin_is_contended(lock);
-}
 #define arch_spin_is_contended arch_spin_is_contended
 
-static __always_inline void arch_spin_lock(arch_spinlock_t *lock)
-{
-       __ticket_spin_lock(lock);
-}
-
-static __always_inline int arch_spin_trylock(arch_spinlock_t *lock)
-{
-       return __ticket_spin_trylock(lock);
-}
-
-static __always_inline void arch_spin_unlock(arch_spinlock_t *lock)
-{
-       __ticket_spin_unlock(lock);
-}
-
 static __always_inline void arch_spin_lock_flags(arch_spinlock_t *lock,
                                                  unsigned long flags)
 {
-- 
1.7.2.3
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] [PATCH 00/14] PV ticket locks without expanding spinlock, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 03/14] x86/ticketlock: Use C for	__ticket_spin_unlock, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 02/14] x86/ticketlock: convert spin loop to C, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 04/14] x86/ticketlock: make large and small	ticket versions of spin_lock the same, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 01/14] x86/ticketlock: clean up types and	accessors, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 10/14] x86/pvticketlock: use callee-save for	lock_spinning, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 06/14] x86/ticketlock: make	__ticket_spin_trylock common, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 05/14] x86/ticketlock: make __ticket_spin_lock	common, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 11/14] x86/ticketlock: don't inline _spin_unlock	when using paravirt spinlocks, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 08/14] x86/ticketlock: collapse a layer of	functions,
Jeremy Fitzhardinge <=
 
- [Xen-devel] [PATCH 14/14] x86/ticketlocks: tidy up	__ticket_unlock_kick(), Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 07/14] x86/spinlocks: replace pv spinlocks with	pv ticketlocks, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 09/14] xen/pvticketlock: Xen implementation for	PV ticket locks, Jeremy Fitzhardinge
 
  
 
[Xen-devel] [PATCH 12/14] x86/ticketlocks: when paravirtualizing	ticket locks, increment by 2, Jeremy Fitzhardinge
[Xen-devel] [PATCH 13/14] x86/ticketlock: add slowpath logic, Jeremy Fitzhardinge
 |  
  
 | 
    |