| 
         
xen-devel
[Xen-devel] [PATCH 11/14] x86/ticketlock: don't inline _spin_unlock	when
 
| 
To:  | 
Peter Zijlstra <peterz@xxxxxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] [PATCH 11/14] x86/ticketlock: don't inline _spin_unlock	when using paravirt spinlocks | 
 
| 
From:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx> | 
 
| 
Date:  | 
Tue, 16 Nov 2010 13:08:42 -0800 | 
 
| 
Cc:  | 
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>,	Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>,	Nick Piggin <npiggin@xxxxxxxxx>,	Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	Jan Beulich <JBeulich@xxxxxxxxxx>, Eric Dumazet <dada1@xxxxxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	Avi Kivity <avi@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>,	Américo Wang <xiyou.wangcong@xxxxxxxxx>,	Linux Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Tue, 16 Nov 2010 13:28:55 -0800 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
In-reply-to:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
References:  | 
<cover.1289940821.git.jeremy.fitzhardinge@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
The code size expands somewhat, and its probably better to just call
a function rather than inline it.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
 arch/x86/Kconfig     |    3 +++
 kernel/Kconfig.locks |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e832768..a615c9c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -531,6 +531,9 @@ config PARAVIRT_SPINLOCKS
 
          If you are unsure how to answer this question, answer N.
 
+config ARCH_NOINLINE_SPIN_UNLOCK
+       def_bool PARAVIRT_SPINLOCKS
+
 config PARAVIRT_CLOCK
        bool
 
diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks
index 88c92fb..3216c22 100644
--- a/kernel/Kconfig.locks
+++ b/kernel/Kconfig.locks
@@ -125,7 +125,7 @@ config INLINE_SPIN_LOCK_IRQSAVE
                 ARCH_INLINE_SPIN_LOCK_IRQSAVE
 
 config INLINE_SPIN_UNLOCK
-       def_bool !DEBUG_SPINLOCK && (!PREEMPT || ARCH_INLINE_SPIN_UNLOCK)
+       def_bool !DEBUG_SPINLOCK && (!PREEMPT || ARCH_INLINE_SPIN_UNLOCK) && 
!ARCH_NOINLINE_SPIN_UNLOCK
 
 config INLINE_SPIN_UNLOCK_BH
        def_bool !DEBUG_SPINLOCK && ARCH_INLINE_SPIN_UNLOCK_BH
-- 
1.7.2.3
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] [PATCH 00/14] PV ticket locks without expanding spinlock, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 03/14] x86/ticketlock: Use C for	__ticket_spin_unlock, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 02/14] x86/ticketlock: convert spin loop to C, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 04/14] x86/ticketlock: make large and small	ticket versions of spin_lock the same, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 01/14] x86/ticketlock: clean up types and	accessors, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 10/14] x86/pvticketlock: use callee-save for	lock_spinning, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 06/14] x86/ticketlock: make	__ticket_spin_trylock common, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 05/14] x86/ticketlock: make __ticket_spin_lock	common, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 11/14] x86/ticketlock: don't inline _spin_unlock	when using paravirt spinlocks,
Jeremy Fitzhardinge <=
 
- [Xen-devel] [PATCH 08/14] x86/ticketlock: collapse a layer of	functions, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 14/14] x86/ticketlocks: tidy up	__ticket_unlock_kick(), Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 07/14] x86/spinlocks: replace pv spinlocks with	pv ticketlocks, Jeremy Fitzhardinge
 
- [Xen-devel] [PATCH 09/14] xen/pvticketlock: Xen implementation for	PV ticket locks, Jeremy Fitzhardinge
 
  
 
[Xen-devel] [PATCH 12/14] x86/ticketlocks: when paravirtualizing	ticket locks, increment by 2, Jeremy Fitzhardinge
 |  
  
 | 
    |