This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] the irq_enter in do_IRQ

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] the irq_enter in do_IRQ
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Sat, 18 Sep 2010 10:22:53 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 17 Sep 2010 19:23:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActW2GY52z5eudSvQ3CQE+pPFskTvA==
Thread-topic: the irq_enter in do_IRQ
Hi, Keir, in do_IRQ,  why do we call the irq_enter only in __do_IRQ_guest and 
the action->handler(), instead of the whole flow of do_IRQ?

I asked this because we noticed a bug that the map/unmap_domain_page() is 
called in a interrupt handler's ack() method, which is not guarded by 
irq_enter(), thus the "ASSERT(!in_irq())" in map/unmap_domain_page() is not 
work expected to guard this calling.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>