This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: the irq_enter in do_IRQ

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] RE: the irq_enter in do_IRQ
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Mon, 20 Sep 2010 15:43:14 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 20 Sep 2010 00:45:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8BA2FF8.2376B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659732A3D0CA5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C8BA2FF8.2376B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActW2GY52z5eudSvQ3CQE+pPFskTvAALwlwVAGP0mMA=
Thread-topic: the irq_enter in do_IRQ

>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Saturday, September 18, 2010 4:00 PM
>To: Jiang, Yunhong
>Cc: xen-devel
>Subject: Re: the irq_enter in do_IRQ
>On 18/09/2010 03:22, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>> Hi, Keir, in do_IRQ,  why do we call the irq_enter only in __do_IRQ_guest and
>> the action->handler(), instead of the whole flow of do_IRQ?
>> I asked this because we noticed a bug that the map/unmap_domain_page() is
>> called in a interrupt handler's ack() method, which is not guarded by
>> irq_enter(), thus the "ASSERT(!in_irq())" in map/unmap_domain_page() is not
>> work expected to guard this calling.
>Okay, xen-unstable:22175 fixes do_IRQ() to be better covered by
>irq_enter()/irq_exit(). Xen-unstable:22177 fixes
>map_domain_page()/unmap_domain_page() to be IRQ safe.
>If these work okay for you then they are candidates for backport for 4.0.2.
> -- Keir
>> Thanks
>> --jyh

Thanks for your changeset very much. As this issue is discovered in our nightly 
test, we will check it later and gives the feedback then.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>