This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xm reboot --wait

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xm reboot --wait
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 07 Aug 2006 15:39:54 +0100
Delivery-date: Mon, 07 Aug 2006 07:40:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <34C6BA0B176095kanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca6L1ijlxHWjiYiEduzrgAKle7CWA==
Thread-topic: [Xen-devel] [PATCH] Fix xm reboot --wait
User-agent: Microsoft-Entourage/

On 7/8/06 11:20 am, "Masaki Kanno" <kanno.masaki@xxxxxxxxxxxxxx> wrote:

> This patch fixed 'xm reboot' to work as you expected with the wait
> option.  The completion of a VM reboot is detected by observing that
> its Domain-ID changes.
> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

What happens currently? Can 'xm reboot' wait forever because it races the
re-creation of the domain?

We need a better test than domid. It's not guaranteed that a domain will get
a new domid when it restarts. Perhaps xend should support the wait option
(since it is involved in the restart), or we could add a restart sequence
count to xenstore (but xm oughtn't to access xenstore directly).

 -- Keir

Xen-devel mailing list