This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xm reboot --wait

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix xm reboot --wait
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Tue, 08 Aug 2006 18:24:19 +0900
Delivery-date: Tue, 08 Aug 2006 02:25:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C0FD0F4A.97C%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C0FD0F4A.97C%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Keir,

>On 7/8/06 11:20 am, "Masaki Kanno" <kanno.masaki@xxxxxxxxxxxxxx> wrote:
>> This patch fixed 'xm reboot' to work as you expected with the wait
>> option.  The completion of a VM reboot is detected by observing that
>> its Domain-ID changes.
>> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>What happens currently? Can 'xm reboot' wait forever because it races the
>re-creation of the domain?

Currently 'xm reboot --wait' never ends. (But VM reboot is completed.)
The wait option waits for the domain termination by chekcing current 
domain list (server.xend.domains). But the domain termination cannot be 
detected because the domain is recreated immediately.

>We need a better test than domid. It's not guaranteed that a domain will get
>a new domid when it restarts. Perhaps xend should support the wait option
>(since it is involved in the restart), or we could add a restart sequence
>count to xenstore (but xm oughtn't to access xenstore directly).

I will remake patch based on your advice.

Best regards,

> -- Keir

Xen-devel mailing list