This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] benign changes to common Linux files

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] benign changes to common Linux files
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 07 Aug 2006 16:05:31 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 07 Aug 2006 08:06:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44D1C55E.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca6MuzDK51QfiYmEduzrgAKle7CWA==
Thread-topic: [Xen-devel] benign changes to common Linux files
User-agent: Microsoft-Entourage/

On 3/8/06 8:43 am, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Here we go.
>>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 02.08.06 19:22 >>>
> On 2 Aug 2006, at 16:31, Jan Beulich wrote:
>> I've run across a few seemingly needless changes to pre-existing Linux
>> files, that thus only bloat the diff when
>> generated against a vanilla tree. Examples below. Could we agree on
>> removing such deltas? Thanks, Jan
> If they are all as obviously trivial as the examples you give, we'd be
> happy to take patches to clean them up.

What tree are you diffing against? The two \n->\t changes in spinlock.h seem
to make sense, but the additional \n in __raw_spin_trylock isn't present in
my vanilla sources. And the line you change in system.h has no
direct equivalent in the vanilla sources since they don't have SMP

 -- Keir

Xen-devel mailing list