This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm

To: Horms <horms@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 11 Jul 2006 16:13:01 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Katsuhito Minai <minai@xxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jul 2006 08:13:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060711123018.14E8E34043@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060711123018.14E8E34043@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 11 Jul 2006, at 13:30, Horms wrote:

Let's not add extra code styles to the tree: either format your code in
Xen style (4-space soft tabs; braces on their own lines) or in Linux
style (hard tabs; K&R style).

Two is already one too many IMHO :-)

As long as each discrete 'tool' or library is self-consistent in which it picks I don't really see a problem. In fact I wouldn't be too bothered about having more than two styles to choose from -- but two-space soft tabs are not an option as far as I'm concerned, which is the main reason I commented. There are more important issues than petty battles over coding standards.

 -- Keir

Xen-devel mailing list