This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [powerpc] initial PowerPC support

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [powerpc] initial PowerPC support
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 11 Jul 2006 16:35:34 +0100
Cc: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jul 2006 08:36:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1152559386.25140.17.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1152559386.25140.17.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 10 Jul 2006, at 20:23, Hollis Blanchard wrote:

        We're using x86/irq.c wholesale, and so need this extra PIC logic.

        PowerPC's page->count_info is a long, because atomic operations are
performed on it. There's no need to change its type for the other
architectures, but this printk needed to change.

        This is the data structure that Linux uses to pass arbitrarily sized
buffers to Xen, so it needs to be in public/ .

We'd like to separate changes to existing files from addition of new files. Could you send a patch that contains all modifications to existing files (including makefiles), and then we'll comment on that separately from the bulk. This is the way we work with the ia64 team -- our pulls from their tree only bring in changes to ia64-specific code. All changes to common code are submitted separately as patches.

I think the changes are all okay to start with: I wonder why you call the arch powerpc rather than ppc? Also the change to the ARCH variable munging in xen/Rules.mk is strange -- do you have trailing characters after 'powerpc' that need to be stripped off? There's a bogus extra file in your tree (XendDomainInfo.py.orig).

What is the current status of this code in terms of stability and features? For example, does it work on a range of PPC systems, can unprivileged guests perform I/O, etc?

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>