This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected
From: Horms <horms@xxxxxxxxxxxx>
Date: Wed, 12 Jul 2006 09:42:20 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Katsuhito Minai <minai@xxxxxxxxxxxxxx>
Delivery-date: Wed, 12 Jul 2006 01:40:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <d66874769ea2e4748023de297796bea6@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060711123018.14E8E34043@xxxxxxxxxxxxxxxxx> <d66874769ea2e4748023de297796bea6@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11+cvs20060403
On Tue, Jul 11, 2006 at 04:13:01PM +0100, Keir Fraser wrote:
> On 11 Jul 2006, at 13:30, Horms wrote:
> >>Let's not add extra code styles to the tree: either format your code 
> >>in
> >>Xen style (4-space soft tabs; braces on their own lines) or in Linux
> >>style (hard tabs; K&R style).
> >
> >Two is already one too many IMHO :-)
> As long as each discrete 'tool' or library is self-consistent in which 
> it picks I don't really see a problem. In fact I wouldn't be too 
> bothered about having more than two styles to choose from -- but 
> two-space soft tabs are not an option as far as I'm concerned, which is 
> the main reason I commented. There are more important issues than petty 
> battles over coding standards.

Sorry, I was niggling a bit. I don't mind too much either, as long
as its clear which directories (or files) use which standard. Though
it is a bit of a mind-warp when you have files from xen/ and some kernel
files open at the same time. I had to get quite good at teaching my
editor what to do for me.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list