This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain

To: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 13 Feb 2006 15:47:53 +0000
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 13 Feb 2006 15:53:35 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <26F44F810A51DF42A127BC2A06BE185E03212D62@pdsmsx404>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <26F44F810A51DF42A127BC2A06BE185E03212D62@pdsmsx404>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 13 Feb 2006, at 15:32, Dong, Eddie wrote:

You should request_clear_vmcs() from within sync_vcpu_execstate().
That'll need a new 'sync' VMX hook function. As well as fixing save,
it will also mean you no longer need to VMCLEAR in
vmx_relinquish_resources() as it will be guaranteed to already be
Yes, my prefer too. thanks!

You'll also need to retrigger the 'do_relaunch' path in arch_vmx_do_resume after a sync. Could do that by setting launch_cpu to -1 after sync'ing.

That'll take you down the else path in arch_vmx_do_resume, and all you need to do is have vmx_request_clear_vmcs() detect and ignore launch_cpu==-1.

 -- Keir

Xen-devel mailing list