This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain

To: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 13 Feb 2006 09:11:35 +0000
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 13 Feb 2006 09:24:39 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <26F44F810A51DF42A127BC2A06BE185E03212D53@pdsmsx404>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <26F44F810A51DF42A127BC2A06BE185E03212D53@pdsmsx404>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 13 Feb 2006, at 03:49, Dong, Eddie wrote:

        But I get another issue recently that need it to be done
earlier. In VMX domain save/restore case, it pauses the VMX domain and
then do states save (and destroy). In this case the arch_vmx_do_resume
is not invoked, so it looks like doing smp_call_function earlier has
other benefits, any suggestion?

You should request_clear_vmcs() from within sync_vcpu_execstate(). That'll need a new 'sync' VMX hook function. As well as fixing save, it will also mean you no longer need to VMCLEAR in vmx_relinquish_resources() as it will be guaranteed to already be done.

If you're implementing save/restore, one thing I notice is that your state save/restore functions assume the current VMCS references the domain of interest -- they will need to be wrapped in VMPTRST/VMPTRLD if the given vcpu is not current.

 -- Keir

Xen-devel mailing list