This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 8 Feb 2006 09:51:53 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 08 Feb 2006 10:03:59 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <FFEFE1749526634699CD3AC2EDB7627A010C6BA2@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <FFEFE1749526634699CD3AC2EDB7627A010C6BA2@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 8 Feb 2006, at 09:28, Jiang, Yunhong wrote:

The patch fixed pin-vcpu issue for VMX domain.
The __vmpclear should be done on the last_launch LP. It also migrate the timers for vmx domain.

Signed-off-by: Yunhong Jiang yunhong.jiang@xxxxxxxxx
Signed-off-by: Eddie Dong eddie.dong@xxxxxxxxx

You don't need to __vmpclear at the time the affinity is changed. You can still do it from within arch_vmx_do_resume() -- it is valid to call smp_call_function() there. That avoids having yet another HVM function, and avoids calling yet another arch_* function from common code.

Rather than calling vmx_remove_timers() from your SMP call function, can you not just call it from vmx_reinstall_timers()? You explain why the pit and hlt timers do not need to be re-activated in vmx_reinstall_timer() -- what about the APIC timer?

There's no need to check active_timer() before calling stop_timer() -- stop_timer does the check for you.

 -- Keir

Xen-devel mailing list