Re: [Xen-ia64-devel] [patch 08/16] kexec/kdump: Minor enhancement to includes in crash.c

[Horms <horms@xxxxxxxxxxxx>]

On Wed, Sep 12, 2007 at 03:39:06PM -0600, Alex Williamson wrote:
> On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> > plain text document attachment (ia64-kexec-crash.c-includes.patch)
> > linux/uaccess.h was being included, but it seems that 
> > really the following includes are needed.
> > 
> > asm/page.h: for __va() and PAGE_SHIFT
> > asm/uaccess.h: for copy_to_user()
> > 
> > I guess that linux/uaccess.h pulls in both asm/page.h and asm/uaccess.h.
> > I notices this while backporting the code to xen's linux-2.6.16.33,
> > which does not have linux/uaccess.h. I'm posting it as I think it is a
> > correct, though somewhat cosmetic fix.
> 
> > Change isn't needed upstream
> > 
> > Index: x/arch/ia64/kernel/crash_dump.c
> > ===================================================================
> > --- x/arch/ia64/kernel/crash_dump.c 2007-04-17 11:44:02.000000000 +0900
> > +++ x/arch/ia64/kernel/crash_dump.c 2007-04-17 11:44:03.000000000 +0900
> > @@ -9,7 +9,8 @@
> >  #include <linux/errno.h>
> >  #include <linux/types.h>
> >  
> > -#include <linux/uaccess.h>
> > +#include <asm/page.h>
> > +#include <asm/uaccess.h>
> >  
> 
>    This should probably be wrapped in a #ifdef CONFIG_XEN for easier
> maintenance.  Thanks,

Thanks.

On the basis that this change isn't needed by upstream Linux
and that it doesn't fix a build or run time problem, although
I still think the change is techincally correct, I have
dropped it.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel