Re: [Xen-ia64-devel] [patch 08/16] kexec/kdump: Minor enhancement to includes in crash.c

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> plain text document attachment (ia64-kexec-crash.c-includes.patch)
> linux/uaccess.h was being included, but it seems that 
> really the following includes are needed.
> 
> asm/page.h: for __va() and PAGE_SHIFT
> asm/uaccess.h: for copy_to_user()
> 
> I guess that linux/uaccess.h pulls in both asm/page.h and asm/uaccess.h.
> I notices this while backporting the code to xen's linux-2.6.16.33,
> which does not have linux/uaccess.h. I'm posting it as I think it is a
> correct, though somewhat cosmetic fix.

> Change isn't needed upstream
> 
> Index: x/arch/ia64/kernel/crash_dump.c
> ===================================================================
> --- x/arch/ia64/kernel/crash_dump.c   2007-04-17 11:44:02.000000000 +0900
> +++ x/arch/ia64/kernel/crash_dump.c   2007-04-17 11:44:03.000000000 +0900
> @@ -9,7 +9,8 @@
>  #include <linux/errno.h>
>  #include <linux/types.h>
>  
> -#include <linux/uaccess.h>
> +#include <asm/page.h>
> +#include <asm/uaccess.h>
>  

   This should probably be wrapped in a #ifdef CONFIG_XEN for easier
maintenance.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel