Re: [Xen-ia64-devel] [patch 13/16] Kdump: Use the machine address for the boot params region

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> plain text document attachment
> (ia64-kexec-mach_addr-of-boot-parameters.patch)
> The boot params region needs to be placed using the machine
> address not the physical address. This is because it represents
> an area of memory that is reserved in the hypervisor and it is
> critical that the same area of machine memory is not trampled
> over during kexec.

> Index: x/arch/ia64/kernel/setup.c
> ===================================================================
> --- x/arch/ia64/kernel/setup.c        2007-05-16 18:26:30.000000000 +0900
> +++ x/arch/ia64/kernel/setup.c        2007-05-16 18:26:37.000000000 +0900
> @@ -340,7 +340,7 @@ reserve_memory (void)
>               efi_memmap_res.start = ia64_boot_param->efi_memmap;
>                  efi_memmap_res.end = efi_memmap_res.start +
>                          ia64_boot_param->efi_memmap_size;
> -                boot_param_res.start = __pa(ia64_boot_param);
> +                boot_param_res.start = kexec_virt_to_phys(ia64_boot_param);

   I can only find kexec_virt_to_phys() defined for CONFIG_XEN in this
patch series.  Won't this fail to build w/ CONFIG_XEN=n?  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel