WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] translate_domain_pte must handle ED bit

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] translate_domain_pte must handle ED bit
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Tue, 21 Feb 2006 10:20:43 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Feb 2006 01:33:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <571ACEFD467F7749BC50E0A98C17CDD802C06D13@pdsmsx403>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <571ACEFD467F7749BC50E0A98C17CDD802C06D13@pdsmsx403>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Mon, Feb 20, 2006 at 10:54:41PM +0800, Tian, Kevin wrote:
> >From: Isaku Yamahata
> >Sent: 2006年2月20日 16:32
> >
> >translate_domain_pte() must handle ED bit explicitly.
> >This case can occur because of vcpu_itc_d().
> >
> >--
> >Yamahata
> 
> Seems a bug, however do you know why it only jumps out now? Seems PAGE_ED is 
> likely on in lookup_domain_mpa...

Perhaps vcpu->arch.dtlb cache hit in vcpu_translate() is very rare
because of tlb cache and VHPT. 
To hit this bug it would be necessary to run a huge amount of
guest domains competing tlb cache and VHPT entries.
It seems that no one does.

Otherwise artificial repeated vhpt/tlb flush in xen for debug might have
this bug appear.


> BTW, bit[53-63] are ignored bits per 4.1.1.5 of SDM2, and then you can just 
> ignore them instead of BUG there. ;-)

Hmm, the current code seems to assume just simply that bit[53-63] and
ED bit[52] can be used for address machine page frame number.
Some clean up might be needed.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel