WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/check: check for headers and libraries in

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/check: check for headers 
and libraries in EXTRA_INCLUDES and EXTRA_LIB"):
> 2011/10/17 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> > Perhaps this would be more easily achieved with "export" ?
> 
> Exported variables are not passed to the called program (chk in this case).

Are you sure ?  One purpose of "export" is to put the variable in the
environment of commands make runs.

> > The check_sys_root stuff seems unrelated ?  Or at least, it's not
> > mentioned in your commit message.  I'm not sure if it should be
> > disentangled but it should definitely be mentioned.  (I'm not much of
> > an expert on tools/check.)
> 
> The check_sys_root call was already there, just moved it to the top,
> but I don't know if it's really necessary.

Why do you move it ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel