Re: [Xen-devel] [PATCH] tools/check: check for headers and libraries in EXTRA_INCLUDES and EXTRA_LIB

[Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>]

2011/10/17 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monne writes ("[Xen-devel] [PATCH] tools/check: check for headers 
> and libraries in EXTRA_INCLUDES and EXTRA_LIB"):
>> tools/check: check for headers and libraries in EXTRA_INCLUDES and EXTRA_LIB
>
> Thanks, but:
>
>>  check-build:
>> -     PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) ./chk build
>> +     PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) 
>> EXTRA_INCLUDES=$(EXTRA_INCLUDES) EXTRA_LIB=$(EXTRA_LIB) ./chk build
>
> Perhaps this would be more easily achieved with "export" ?

Exported variables are not passed to the called program (chk in this case).

>>  has_header() {
>> +     check_sys_root || return 1
>> +
>
> The check_sys_root stuff seems unrelated ?  Or at least, it's not
> mentioned in your commit message.  I'm not sure if it should be
> disentangled but it should definitely be mentioned.  (I'm not much of
> an expert on tools/check.)

The check_sys_root call was already there, just moved it to the top,
but I don't know if it's really necessary.

> Also, I should probably wait with applying this until after your
> revised USER_* flags variables patch, since you probably want to do a
> similar job for USER_ ?

I'm going to send a series now with the two patches.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel