Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client
From:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date:	Tue, 28 Jun 2011 11:59:31 +0100
Cc:	Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date:	Tue, 28 Jun 2011 04:02:59 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1309252470.32717.285.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups:	chiark.mail.xen.devel
References:	<1309187551-21538-1-git-send-email-anthony.perard@xxxxxxxxxx> <1309187551-21538-4-git-send-email-anthony.perard@xxxxxxxxxx> <19976.44330.128977.805588@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTin=_y1jwx4XFcOgjBcEs2y4r+40Ow@xxxxxxxxxxxxxx> <1309252470.32717.285.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Ian Campbell writes ("Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP 
client"):
> I think Ian was only suggesting to remove the ifdef's from the main flow
> of code and you've done that for most of the uses with your DEBUG_GEN*
> but here perhaps you could also define and call functions which are
> empty in the non-debug case. e.g. DEBUG_GEN_START, DEBUG_GEN_END,
> DEBUG_GEN_REPORT?

Quite so.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [PATCH v2] qemu_ram_ptr_length: take ram_addr_t as arguments, Peter Maydell

Next by Date:

Re: [Xen-devel] [PATCH 0 of 5] v2: Nested-p2m cleanups and locking changes, Christoph Egger

Previous by Thread:

Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client, Ian Campbell

Next by Thread:

Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client, Anthony PERARD

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client