WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH V5 2/3] libxl: Introduce libxl_internal_types

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH V5 2/3] libxl: Introduce libxl_internal_types.idl.
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Mon, 27 Jun 2011 16:40:16 +0100
Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 27 Jun 2011 08:49:03 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Ii064wQDUMTwB9tichasYquOBoZxp6O6cY9sbT/JY80=; b=fEdakQ7XKxyhKK39oQduIWb9jcV1dsIJ6PM4t6L58A2e0PRH0az0OCtyDIfBBMhEWo 7J7B0t7q8S4ZJxiSx9AT2WRgB6DG1CbQRX983WMoEv+u/XcHKgIQ+gKKhjAIkKlps//u EYBifodOFRagqpFuRKtA6sla5tFk+SnHQvYqI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=Uf1Eg2MjU0ZqwPTYhg0jcoQ1NqMxL1gGQhu454mZjlhmz1IHStuiKfXH3iCHt9nBKW Qb5RI9rww+cKO1VpqT5xqDdGaeNqnvnhhr73yup8Soe5gVQuniJt7wIXH5OclOUKqWD5 FMOqKGFFsDGLk5YwK6+f0I2QXoDGrRkRdQJTQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1309188011.32717.244.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1309187551-21538-1-git-send-email-anthony.perard@xxxxxxxxxx> <1309187551-21538-3-git-send-email-anthony.perard@xxxxxxxxxx> <1309188011.32717.244.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, Jun 27, 2011 at 16:20, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Mon, 2011-06-27 at 16:12 +0100, Anthony PERARD wrote:
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> ---
>>  tools/libxl/Makefile                 |   10 +++++++++-
>>  tools/libxl/gentypes.py              |   15 ++++++++-------
>>  tools/libxl/libxl_internal.h         |    1 +
>>  tools/libxl/libxl_internal_types.idl |   10 ++++++++++
>
> Do you not need to update .hgignore?

I don't use mercurial! :)
But no, the file generated will be catch by:
^tools/libxl/_.*\.h$

>>  4 files changed, 28 insertions(+), 8 deletions(-)
>>  create mode 100644 tools/libxl/libxl_internal_types.idl
>>
>> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
>> index bfe9c58..f148ad3 100644
>> --- a/tools/libxl/Makefile
>> +++ b/tools/libxl/Makefile
>> @@ -35,7 +35,7 @@ LIBXL_OBJS-$(CONFIG_IA64) += libxl_nocpuid.o
>>  LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \
>>                       libxl_dom.o libxl_exec.o libxl_xshelp.o libxl_device.o 
>> \
>>                       libxl_internal.o libxl_utils.o libxl_uuid.o 
>> $(LIBXL_OBJS-y)
>> -LIBXL_OBJS += _libxl_types.o libxl_flask.o
>> +LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_internal_types.o
>>
>>  $(LIBXL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) 
>> $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl)
>>
>> @@ -79,14 +79,22 @@ _libxl_paths.h: genpath
>>  libxl_paths.c: _libxl_paths.h
>>
>>  libxl.h: _libxl_types.h
>> +libxl_internal.h: _libxl_internal_types.h
>>
>>  $(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
>> +$(LIBXL_OBJS): libxl_internal.h
>>
>>  _libxl_%.h _libxl_%.c: libxl.idl gen%.py libxl%.py
>>       $(PYTHON) gen$*.py libxl.idl __libxl_$*.h __libxl_$*.c
>
> If you simply s/gen$*.py/gentypes.py/ and s/libxl.idl/libxl$*.idl/g and
> leave the other patterns does this rule work for both IDL files?

Yes, it's works, with a `mv libxl.idl libxl_types.idl`. I thought this
rules was used by something else.

>>       mv __libxl_$*.h _libxl_$*.h
>>       mv __libxl_$*.c _libxl_$*.c
>>
>> +.NOTPARALLEL: _libxl_internal_types.h _libxl_internal_types.c
>
> I'd been wondering how to do that!

Better than a -j1, first time I use it but seams to work fine.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel