WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH RESENT] libxl: add all pci devices to xenstore at

To: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH RESENT] libxl: add all pci devices to xenstore at once (during VM create)
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 17 Jun 2011 18:49:10 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Jun 2011 10:49:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <dde7bd609f9b2e795e9c.1307703556@devel14>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <alpine.DEB.2.00.1106101149230.12963@kaball-desktop> <dde7bd609f9b2e795e9c.1307703556@devel14>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Marek Marczykowski writes ("[Xen-devel] [PATCH RESENT] libxl: add all pci 
devices to xenstore at once (during VM create)"):
> +    ret = libxl__create_pci_backend(gc, domid, d_config->pcidevs, 
> d_config->num_pcidevs);
> +    if (ret < 0) {
> +             LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "libxl_create_pci_backend 
> failed: %d", ret);
> +        goto error_out;
> +    }

This is a good patch but can you please keep your lines to 75
characters or so ?  I know libxl already has areas full of long lines,
but we'd rather not introduce any more.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel