Re: [Xen-devel] [PATCH] libxl: off by one fix for new network-at

Marek Marczykowski writes ("[Xen-devel] [PATCH] libxl: off by one fix for new 
network-attach args parsing"):
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -1238,7 +1238,7 @@ static int match_option_size(const char 
>      return !rc;
>  }
>  #define match_option(_prefix, _arg, _oparg) \
> -    match_option_size((_prefix "="), sizeof((_prefix)) + 1, (_arg), 
> &(_oparg))
> +    match_option_size((_prefix "="), sizeof((_prefix)), (_arg), &(_oparg))

I haven't applied your patch yet, so could you fold this in and resend
please ?

Why do you use _'d names for the macro formal parameters ?  This is
not our usual coding style.

Finally can you please make sure that your patch has lines of only
around 75 characters, and call the macro MATCH_OPTION since it's not a
normal function.

thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH RESENT] libxl: add all pci devices to xenstore at once (during VM create), Ian Jackson

Next by Date:

Re: [Xen-devel] Domains not being destroyed properly, Nathan March

Previous by Thread:

[Xen-devel] [PATCH] libxl: off by one fix for new network-attach args parsing, Marek Marczykowski

Next by Thread:

[Xen-devel] [PATCH RESENT] xl: Use macros for param parsing in network-attach, to prevent use explicit sizeof("param"), Marek Marczykowski

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] libxl: off by one fix for new network-attach arg