WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH RESENTv2] libxl: add all pci devices to xenstore

To: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH RESENTv2] libxl: add all pci devices to xenstore at once (during VM create)
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 21 Jun 2011 17:38:33 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Jun 2011 09:39:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ab51f4a066155b5da552.1307703750@devel14>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <alpine.DEB.2.00.1106101149230.12963@kaball-desktop> <ab51f4a066155b5da552.1307703750@devel14>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Marek Marczykowski writes ("[Xen-devel] [PATCH RESENTv2] libxl: add all pci 
devices to xenstore at once (during VM create)"):
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -521,6 +521,11 @@ static int do_domain_create(libxl__gc *g
>  
>      for (i = 0; i < d_config->num_pcidevs; i++)
>          libxl__device_pci_add(gc, domid, &d_config->pcidevs[i], 1);
> +    ret = libxl__create_pci_backend(gc, domid, d_config->pcidevs, 
> d_config->num_pcidevs);
> +    if (ret < 0) {
> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "libxl_create_pci_backend failed: 
> %d", ret);
> +        goto error_out;
> +    }

There is an indenting error here.

Also your lines are still >75 characters.  Please wrap them
appropriately, including splitting strings if necessary.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel