WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 22 May 2009 15:55:31 +0100
Cc:
Delivery-date: Fri, 22 May 2009 07:53:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090522143610.GW10166@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C63AA5FE.6E47%keir.fraser@xxxxxxxxxxxxx> <4A16B740.90809@xxxxxxxxxxxxx> <20090522143610.GW10166@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080505)
Samuel Thibault wrote:

> Stefano Stabellini, le Fri 22 May 2009 15:31:28 +0100, a écrit :
>> Keir Fraser wrote:
>>> Yeah, I'd take a patch to add a nice clear comment about this to blkif.h.
>>> ;-)
>> Is this comment clear enough?
> 
> Could you also document whether the 'sectors' node in the xenstore is
> expressed in sector size or in 512 sectors?



OK.

---

diff -r 61404d971c92 xen/include/public/io/blkif.h
--- a/xen/include/public/io/blkif.h     Thu May 21 04:31:47 2009 +0100
+++ b/xen/include/public/io/blkif.h     Fri May 22 15:54:29 2009 +0100
@@ -84,6 +84,14 @@
  */
 #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11
 
+/* 
+ * first_sect and last_sect in blkif_request_segment, as well as
+ * sector_number in blkif_request are all expressed in 512 bytes units,
+ * however they must be properly aligned to the real sector size of
+ * the physical disk, that is reported in the "sector-size" node in
+ * backend xenbus info.
+ * Also the "sectors" node on xenbus is expressed in 512 bytes units.
+ */
 struct blkif_request_segment {
     grant_ref_t gref;        /* reference to I/O buffer frame        */
     /* @first_sect: first sector in frame to transfer (inclusive).   */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel