WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 21 May 2009 14:17:11 +0100
Cc:
Delivery-date: Thu, 21 May 2009 06:15:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090521120849.GA5806@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A153DC4.5070803@xxxxxxxxxxxxx> <20090521120849.GA5806@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080505)
Samuel Thibault wrote:

> Stefano Stabellini, le Thu 21 May 2009 12:40:52 +0100, a écrit :
>> The first and last sector as well as the sector number of the request is
>> expressed in 512 bytes units, independently from the real sector size.
>>      req->id = (uintptr_t) aiocbp;
>> -    req->sector_number = aiocbp->aio_offset / dev->info.sector_size;
>> +    req->sector_number = aiocbp->aio_offset / 512;
>>  
> 
> Oh?!
> 
> That needs to be better documented in xen/include/public/io/blkif.h,
> then.  I'm however wondering whether this shouldn't actually be fixed in
> the blkback/cdrom interface instead.
> 

Yeah, I am surprised as you are, but the linux blkfront does the same
thing so I prefer to avoid changing the protocol now.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel