WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 21 May 2009 06:32:30 -0700
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 21 May 2009 06:33:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090521132015.GU5806@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnaFvI40OnQC79fQlCGsEaD1OeecQAAaSHS
Thread-topic: [Xen-devel] [PATCH 1 of 2] blkfront: sector size > 512
User-agent: Microsoft-Entourage/12.17.0.090302
On 21/05/2009 06:20, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxx> wrote:

>> Yeah, I am surprised as you are, but the linux blkfront does the same
>> thing so I prefer to avoid changing the protocol now.
> 
> Well, it's not about changing the protocol, it's about fixing drivers
> doing the wrong thing according to the documentation.  What is the use
> of the xenstore sector_size value if not here?

It's due to the protocol having evolved a bit. The xenstore sector_size was
added a bit later, specifically after testing on CD-ROM drives, to require
that frontends issue sector_size-aligned and -sized requests. Otherwise
Linux blkdev subsystem was dropping the reqs on the floor. But we did not
change the wire request format at that time.

Yeah, I'd take a patch to add a nice clear comment about this to blkif.h.
;-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel