|
xen-devel
Re: [Xen-devel] [PATCH][ioemu] fix PCI bar mapping
|
To: |
"Cui, Dexuan" <dexuan.cui@xxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH][ioemu] fix PCI bar mapping |
|
From: |
Simon Horman <horms@xxxxxxxxxxxx> |
|
Date: |
Fri, 8 May 2009 12:05:32 +1000 |
|
Cc: |
Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>, "Zhao, Yu" <yu.zhao@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx> |
|
Delivery-date: |
Thu, 07 May 2009 19:05:58 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<EADF0A36011179459010BDF5142A45751555F260@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<EADF0A36011179459010BDF5142A45751555F260@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, May 05, 2009 at 08:37:56PM +0800, Cui, Dexuan wrote:
> dbb8aafa702b8b4f5568e08641d98471fd04e0f8 has a bug:
> The virtual CMD value we get from reg_entry->data is not the proper value
> because reg_entry->data only holds the emulated bits and the
> PCI_COMMAND_IO/PCI_COMMAND_MEMORY bits are not in it.
> Instead, we can use pt_pci_read_config(&ptdev->dev, PCI_COMMAND, 2) to get
> the proper value.
>
> We should only update the mapping of the related BAR, NOT the mappings of ALL
> BARs.
>
> In pt_exp_rom_bar_reg_write(), we should also update the mapping. And for
> PCI_ROM_SLOT, when the PCI_ROM_ADDRESS_ENABLE bit is 0, we should not have
> the mapping.
>
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
Hi,
this patch also seems to resolve the problem that I was seeing
where Intel NICs were not usable.
Tested-by: Simon Horman <horms@xxxxxxxxxxxx>
--
Simon Horman
VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia
H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home