| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] RE: [PATCH][ioemu] fix PCI bar mapping
|
To: |
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] RE: [PATCH][ioemu] fix PCI bar mapping |
|
From: |
"Cui, Dexuan" <dexuan.cui@xxxxxxxxx> |
|
Date: |
Thu, 7 May 2009 20:13:21 +0800 |
|
Accept-language: |
zh-CN, en-US |
|
Acceptlanguage: |
zh-CN, en-US |
|
Cc: |
"Zhao, Yu" <yu.zhao@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx> |
|
Delivery-date: |
Thu, 07 May 2009 05:14:11 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<18946.49676.482876.244423@xxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<EADF0A36011179459010BDF5142A45751555F260@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090507163136.983F.27C06F64@xxxxxxxxxxxxxxx> <18946.49676.482876.244423@xxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcnPBLAed/QduCJlRSi4oIFBYNyHxQACDhCw |
|
Thread-topic: |
[PATCH][ioemu] fix PCI bar mapping |
Ian Jackson wrote:
> Yuji Shimada writes ("Re: [PATCH][ioemu] fix PCI bar mapping"):
>> pt_pci_read_config should not be used to read configuration
>> registers. pt_pci_read_config emulates access to read the registers
>> from guest software. Many functions which are not relevant are
>> executed in pt_pci_read_config. So side effects may occur. Instead,
>> you can use pc_read_word of libpci just to read configuration
>> registers.
>
> Should we be reverting Cui's patch and fix the problem some other
> way ?
I have posted a new patch according to Yuji's comment.
>
>> Or, there is another approach. It is that you remove emu_mask from
>> writable_mask in pt_cmd_reg_write. Then you can get the proper value
>> from reg_entry->data.
Please help to review my newly-posted patch for this approach.
>
> It would be nice to get this sorted for the 3.4 release, which is
> imminent ...
>
> Ian.
Thanks,
-- Dexuan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home