WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] xend: fix the pci BDF format string

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] xend: fix the pci BDF format string
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Fri, 8 May 2009 10:02:42 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Delivery-date: Thu, 07 May 2009 19:04:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090508005511.GA23312@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A45751555F97C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090508005511.GA23312@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnPd6b2AW/nYrLzRj+3PZOVJxS2aQACMODw
Thread-topic: [Xen-devel] [PATCH] xend: fix the pci BDF format string
Sorry, I should have used a better description. Now the patch has been checked 
in with the description...
Anyway, we can use 'hg annotate tools/python/xen/xm/main.py" to locate which 
c/s changed that line easily.

Thanks,
-- Dexuan

-----Original Message-----
From: Simon Horman [mailto:horms@xxxxxxxxxxxx] 
Sent: 2009年5月8日 8:55
To: Cui, Dexuan
Cc: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx; Yosuke Iwamatsu
Subject: Re: [Xen-devel] [PATCH] xend: fix the pci BDF format string

On Thu, May 07, 2009 at 10:55:40AM +0800, Cui, Dexuan wrote:
> Fix the typo introduced by changeset 19446: 2ef77b4bdf58.

Hi,

I can confirm that this patch fixes the problem, but would
it be possible to have a more descriptive changelog to avoid
having to look up what it was that 19446:2ef77b4bdf58 did?

Perhaps:

xend: Fix the PCI BDF format string used in the output of xm 
pci-list-assignable-devices

This fixes a typo introduced by changeset 19446: 2ef77b4bdf58

> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
> 
> diff -r fb3e1e84d8f4 tools/python/xen/xm/main.py
> --- a/tools/python/xen/xm/main.py   Wed May 06 12:40:51 2009 +0100
> +++ b/tools/python/xen/xm/main.py   Thu May 07 10:45:47 2009 +0800
> @@ -2197,7 +2197,7 @@ def xm_pci_list_assignable_devices(args)
> 
>      devs =  server.xend.node.pciinfo()
> 
> -    fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x:%(func)01x"
> +    fmt_str = "%(domain)04x:%(bus)02x:%(slot)02x.%(func)01x"
>      for x in devs:
>          pci = parse_pci_info(x)
>          print fmt_str % pci

-- 
Simon Horman
  VA Linux Systems Japan K.K. Satellite Lab in Sydney, Australia
  H: www.vergenet.net/~horms/            W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel