RE: [Xen-devel] [PATCH 0/5] VT-d support for PV guests

[Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>]

[Allen M Kay]
>> 
>> While adding the PV VT-d support I also noticed that there is a lot
>> of duplicated and unused code dealing with VT-d.  This really needs
>> to be cleaned up properly.  I don't know if the original VT-d
>> submitters already have made plans for doing this.
>> 
>> 

> Other than the hardware wait loops which is something we need to
> clean up, can you give some example of duplicated/unused code in
> vt-d directory?

>From the top of my head:

    iommu_set/free_pgd()  in xen/drivers/passthrough/vtd/x86/vtd.c
    iommu_page_unmapping() in xen/drivers/passthrough/vtd/iommu.c

There's probably more that I can't think of right now.

        eSk

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel