This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix broken ACM

On 23 Jun 2005, at 15:57, Stefan Berger wrote:

ok, i see the point. the problem is because i moved some codes
(acm_init() and acm_init_binary_policy()) to acm_hooks.h. now it seems
better to move them back. but it is weird that i got no problem with
gcc 3.3.5

could you please try again with the new patch below?

I tried it with your attached patch. There was an unused function when
trying out the NULL policy. The attached patch on top of yours and things
compile fine.

I'm still confused what these patches are aiming to fix. If we are building 'NULL' security policy then all the hooks should compile away to nothing and acm core files do not get built. So why do they need patching with ifdef's conditional on whether or not the policy is 'NULL'?

Currently, if you re-enable building of acm/ directory in the Xen root Makefile, yet the ACM_USE_SECURITY_POLICY is NULL_POLICY, the build will certainly fail. But I don;t see why we would want to support that. :-)

 -- Keir

Xen-devel mailing list