WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix broken ACM

To: aq <aquynh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix broken ACM
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Thu, 23 Jun 2005 00:18:16 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 23 Jun 2005 04:17:21 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9cde8bff050622205635e60050@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
aq <aquynh@xxxxxxxxx> wrote on 06/22/2005 11:56:07 PM:

> On 6/23/05, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> > xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 06/22/2005 01:40:16 PM:
> > 
> > > The latest change to ACM makes it fail to compile. This patch fixes 
the
> > problem.
> > >
> > > Signed-off-by: Nguyen Anh Quynh <aquynh@xxxxxxxxx>
> > >
> > > $ diffstat acm.patch
> > >  acm/acm_core.c          |   61 ---------------------
> > >  include/acm/acm_hooks.h |  135
> > ++++++++++++++++++++++++++++++++++--------------
> > >  2 files changed, 96 insertions(+), 100 deletions(-)
> > > [attachment "acm.patch" deleted by Stefan Berger/Watson/IBM]
> > 
> > This patch seems to work for gcc 4.0.0 (FC4), but the resulting source
> > does not compile with gcc 3.4.3 (FC3). I will try to find a common
> > solution. I think the problem is related to gcc 3.4.3 having a limit 
on
> > inline functions.
> 
> it builds fine for me on gcc 3.3.5
> 
> $ gcc -v
> Reading specs from /usr/lib/gcc-lib/i486-linux/3.3.5/specs
> Configured with: ../src/configure -v
> --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang
> --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info
> --with-gxx-include-dir=/usr/include/c++/3.3 --enable-shared
> --with-system-zlib --enable-nls --without-included-gettext
> --enable-__cxa_atexit --enable-clocale=gnu --enable-debug
> --enable-java-gc=boehm --enable-java-awt=xlib --enable-objc-gc
> i486-linux
> Thread model: posix
> gcc version 3.3.5 (Debian 1:3.3.5-8ubuntu2)

It seems to be missing a couple of prototypes.

In file included from dom0_ops.c:22:
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h: In function `acm_init':
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:359: warning: implicit 
declaration of function `acm_set_endian'
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:364: warning: implicit 
declaration of function `acm_init_chwall_policy'
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:366: error: 
`acm_chinesewall_ops' undeclared (first use in this function)
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:366: error: (Each 
undeclared identifier is reported only once
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:366: error: for each 
function it appears in.)
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:368: error: 
`acm_null_ops' undeclared (first use in this function)
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:372: warning: implicit 
declaration of function `acm_init_ste_policy'
/xen/xeno-unstable.bk/xen/include/acm/acm_hooks.h:374: error: 
`acm_simple_type_enforcement_ops' undeclared (first use in this function)
make[2]: *** [dom0_ops.o] Error 1
make[2]: Leaving directory `/xen/xeno-unstable.bk/xen/common'
make[1]: *** [/xen/xeno-unstable.bk/xen/xen] Error 2
make[1]: Leaving directory `/xen/xeno-unstable.bk/xen'
make: *** [xen] Error 2


Once those are fixed the following happens:

ld   -m elf_i386  -T x86_32/xen.lds -N \
    boot/x86_32.o /xen/xeno-unstable.bk/xen/common/common.o 
/xen/xeno-unstable.bk/xen/drivers/char/driver.o 
/xen/xeno-unstable.bk/xen/drivers/acpi/driver.o 
/xen/xeno-unstable.bk/xen/arch/x86/arch.o -o 
/xen/xeno-unstable.bk/xen/xen-syms
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x121a): In function 
`do_dom0_op':
: undefined reference to `acm_primary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x1246): In function 
`do_dom0_op':
: undefined reference to `acm_secondary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x126b): In function 
`do_dom0_op':
: undefined reference to `acm_primary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x1288): In function 
`do_dom0_op':
: undefined reference to `acm_secondary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x12b0): In function 
`do_dom0_op':
: undefined reference to `acm_primary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x12c0): In function 
`do_dom0_op':
: undefined reference to `acm_secondary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x12d7): In function 
`do_dom0_op':
: undefined reference to `acm_free_domain_ssid'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x134e): In function 
`do_dom0_op':
: undefined reference to `acm_primary_ops'
/xen/xeno-unstable.bk/xen/common/common.o(.text+0x1376): In function 
`do_dom0_op':
: undefined reference to `acm_init_domain_ssid'
[...]



gcc -v
Reading specs from /usr/lib/gcc/i386-redhat-linux/3.4.3/specs
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info --enable-shared --enable-threads=posix 
--disable-checking --with-system-zlib --enable-__cxa_atexit 
--disable-libunwind-exceptions --enable-java-awt=gtk 
--host=i386-redhat-linux
Thread model: posix
gcc version 3.4.3 20050104 (Red Hat 3.4.3-13)


What is the compiler problem that you fixed with your patch?

  Stefan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel