This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix broken ACM

To: aq <aquynh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix broken ACM
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Thu, 23 Jun 2005 10:57:21 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 14:56:21 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9cde8bff0506230056a11146a@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 06/23/2005 03:56:52 AM:

> On 6/23/05, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> > aq <aquynh@xxxxxxxxx> wrote on 06/22/2005 11:56:07 PM:
> > 
> > > On 6/23/05, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> > > > xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 06/22/2005 01:40:16 

> > 
> ok, i see the point. the problem is because i moved some codes
> (acm_init() and acm_init_binary_policy()) to acm_hooks.h. now it seems
> better to move them back. but it is weird that i got no problem with
> gcc 3.3.5
> could you please try again with the new patch below? 

I tried it with your attached patch. There was an unused function when 
trying out the NULL policy. The attached patch on top of yours and things 
compile fine.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

Attachment: acm3.1.patch
Description: Binary data

Xen-devel mailing list