[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: fix unmapped access trapping on GICv2 hardware
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 11 Mar 2026 15:28:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h2r0/8ej73WI0PEnvNExoigrPoI3S4hHyeVt31lA25I=; b=E10sITTDsFYcRe1UWhcyZTcNxVi3I5JFBi0yVGRoCZX1rw6DY+T+QHMMxZYW9zqIWUUB1gB7oJG4I6w2l97Inv8BUgZ5OONY3ucl6xUO+9EWvJarNtTNLCsrD39+ZEf36G01vPh2Cz3LbXQ+KqYNg8sqpxQtIv0niRK1tyT3BPdbcy0MULz/racnZ3CiK0AKi9RxA7L5jiFDEbCEhYdaARC/e/RWWER4SBvZRkDx8GOHVQG81+Oxjhko71qoGaVMrTqfcu3gYgVFIzBCh5HYNqBejLPnQvqHdIJohrXYm+EADUVwLq432zPlniL5xNh0PrDJiA4BDiPxggLgdJfdmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l8qgotWeY4JcGfaWTWkqNpf0tPh9GWygkuU0Y5fp4jcItiNM0lhISiDydHrMpQHmj/3MKDcioH+AIN7VHwcXtr1AU/Jm2rBGpBnY6LOOeL7mFk5DgcZd9VolB8zSfXn6w8Y1on0v2H/IdmEP3kmwnEdNRgyo31/A0CXEXdvhTtFbW3+UuT5UTcDsIpy4DqD+msuzYc47Wtoybx3PJhvllD6+BA/HcXxZMdIGW6H9ypjNoaCJwj+U3STxxQYZdswLxdv7/SjSaDiJt8LpouSfacZmPboygBmNvW5cxlP1Lz26Gb3rCdhlN0wWFA3xkUJHIpAu/bq8vGmsi+21MvAF5Q==
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 11 Mar 2026 14:29:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/03/2026 15:09, Stewart Hildebrand wrote:
> On 2/18/26 12:16, Orzel, Michal wrote:
>>
>>
>> On 18/02/2026 15:21, Stewart Hildebrand wrote:
>>> Gentle ping.
>> Sorry, I'm quite busy these days.
>>
>>>
>>> To be clear, domU interrupts with vGICv2 are currently broken when
>>> XEN_DOMCTL_CDF_trap_unmapped_accesses is not set.
>>>
>>> On 2/5/26 14:01, Stewart Hildebrand wrote:
>>>> Since 4dbcb0653621, the vGICv2 CPU interface is mapped in a deferred
>>>> manner. On domains with XEN_DOMCTL_CDF_trap_unmapped_accesses unset on
>>>> GICv2 hardware, the vGICv2 CPU interface fails to be mapped. A visible
>>>> symptom is that a domU gets stuck at:
>>>>
>>>> [ 0.177983] smp: Bringing up secondary CPUs ...
>>>>
>>>> Move the 2nd check_p2m earlier so it's prioritized over try_handle_mmio.
>>>>
>>>> Fixes: 980aff4e8fcd ("xen/arm: Add way to disable traps on accesses to
>>>> unmapped addresses")
>>>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>> I investigated whether the reordering is safe and it looks ok:
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Thanks! Is there any other feedback? Is this ready for commit?
It's ready, will commit tomorrow.
~Michal
|
