[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: fix unmapped access trapping on GICv2 hardware
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 11 Mar 2026 10:09:54 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4YOctJBCJL3jsVpHCrS9Gm56uQh0xSYflxixPkOSk0=; b=s51oPup+ET5DtgpUeZyIuhOQ4/fUpsAetxFhZ1KhxSacthz26RbbKsnS/gY5LDJ81FPkxdRj6CkrfXKdFkGArgurcvJcdV4I7TUWK4Huz1vCEMene41Sje6ndSWNIzSdZ8tuuZCY0cZN1IglcaxEPrh6kosxrms6OCxb2uIgSVKGCkdlHboSPIPY5iEEI/6Dkc+BYUxrhUHFbc75DV8ylQFm02tR7yF71uMmt95dBps8BbUrki0dxLqAglKLHXGjVkt/4vdZdYfRwY7GeUVQDSKt3hG9RQMttzJKz7k5pjFeBPhtnsKk5PSNhn8zU76BWXnVXDvq6U6o8M/SPcPZvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xHSB9k28sB7kUHz4QI13a+wqhdHaQdN+uJd3uXfo1wRZ1Ea0p6wCPjR4LUUXM9LbmiYzghENDXdop8LsnlEM50FOrYsm9W6Ubav+9z7LKfqCDz6pnFJDRs9gta64/R7wtz5wgHiBeHboPvcEJk0X4ExKGdaYzJ24ijdQppJsUxfkc3w0aRZZSuWzvQtosDDs4hkckd5vMqJE0dahi401Mk5vQhp6zDX0JwZi9zV9tUOAxU7jthtxLhSa8rxqiwVzn32SleNqIqYonOaFLc7kFnHZ6VHZ5+mN5gHj2c50AQVF80FV8kabDdNw3OcutUkkokoKKAedPAByukNQrvgp7g==
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 11 Mar 2026 14:10:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2/18/26 12:16, Orzel, Michal wrote:
>
>
> On 18/02/2026 15:21, Stewart Hildebrand wrote:
>> Gentle ping.
> Sorry, I'm quite busy these days.
>
>>
>> To be clear, domU interrupts with vGICv2 are currently broken when
>> XEN_DOMCTL_CDF_trap_unmapped_accesses is not set.
>>
>> On 2/5/26 14:01, Stewart Hildebrand wrote:
>>> Since 4dbcb0653621, the vGICv2 CPU interface is mapped in a deferred
>>> manner. On domains with XEN_DOMCTL_CDF_trap_unmapped_accesses unset on
>>> GICv2 hardware, the vGICv2 CPU interface fails to be mapped. A visible
>>> symptom is that a domU gets stuck at:
>>>
>>> [ 0.177983] smp: Bringing up secondary CPUs ...
>>>
>>> Move the 2nd check_p2m earlier so it's prioritized over try_handle_mmio.
>>>
>>> Fixes: 980aff4e8fcd ("xen/arm: Add way to disable traps on accesses to
>>> unmapped addresses")
>>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
> I investigated whether the reordering is safe and it looks ok:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks! Is there any other feedback? Is this ready for commit?
|
