[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 4/4] scripts/config: hook to automation build script
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, dmukhin@xxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Sat, 24 Jan 2026 13:22:59 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/HVLmgfdtdtGuw125hCDS5O64oIRU4lHyZZwaBUw0ag=; b=uPeMdpyDOwVc6zzLB/SR9jE0+T5/Y1KlGQv7T9LGfzIBfSnLJ5aj2kQkRch+dAg42MJMZcmK0+dTZFt6hRO0OTxw+N+0veuE/+4xxMDeMyM9FQzps5ZV5IyUeCb3ikDkLM9arrtO4mfGdNJHbovY4VtTZqFmMlXDWkk099e4YJ32ZMnvrZQ79S9E4A+aiaqa5vG+r6DAtHs/vRBDp7a+f0bl5cyBz5D29qeNNEhiHH8IQQfngFpe5yN1gimIzL6CT8lfs8e7qf1Un8IrvM7DUp5twrcjLhIxJgOUArRI47ZulrP3iDdhTTsJ0b7lKJeQTZPdwXSOGztNsqHyPapXUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yTbVLqCUWToosBicsZZ9wSNiIgdJPPvvZMSo4dznudoy0hJk2OS7pXkNT8WdBNB8aUCiYY6hBQdsJdy64Pv+CJxh4O3HHPJcT6wKe5UbSeiBp5KinpEC2Z5P/OTSkoHiiTvNZPHdTiTvqA/o8QyZNeQvWiKPq+9msG05qHE+CJTy5H+AaahANtBgl/aCoo8k68ytp8vMlALh6xPUOj1BAH0PW8eW0Y8yn81WIhhT+3OVrww3+lxuToZyD9pp8YSj7/coyE+OSWDrldOUmLCeczyPMtCXFP4gEpbM6YDlouZFE+RZH/vRt1rgVkA6FBHW08bQy6wAhkZ+iupLhC2Abg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, michal.orzel@xxxxxxx, roger.pau@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Sat, 24 Jan 2026 13:23:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/01/2026 12:32 am, Stefano Stabellini wrote:
> On Thu, 15 Jan 2026, dmukhin@xxxxxxx wrote:
>> From: Denis Mukhin <dmukhin@xxxxxxxx>
>>
>> Use the new .config manipulation tool to toggle CONFIG_DEBUG in the
>> Xen automation build script.
>>
>> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
>> ---
>> automation/scripts/build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/automation/scripts/build b/automation/scripts/build
>> index 7a81d229decd..ee1127c53dc5 100755
>> --- a/automation/scripts/build
>> +++ b/automation/scripts/build
>> @@ -27,7 +27,7 @@ else
>> # Start off with arch's defconfig
>> make -C xen defconfig
>>
>> - echo "CONFIG_DEBUG=${debug}" >> xen/.config
>> + xen/scripts/config --file xen/.config -${debug} DEBUG
> I'd suggest to add:
>
> debug="${debug:-n}"
>
> before calling xen/scripts/config to avoid errors in case debug is not
> set
>
> I could make the change on commit if you are OK with it
$debug is always set in automation, which is why the script is written
this way. But being resilient might be better.
>> if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
>> echo "${EXTRA_XEN_CONFIG}" >> xen/.config
This part of context is the same pattern, and wants a similar
adjustment, although maybe the script wants a bulk adjustment mode.
This pattern is also repeated in the Eclair scripting too.
~Andrew
|
