[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 4/4] scripts/config: hook to automation build script



On Thu, 15 Jan 2026, dmukhin@xxxxxxx wrote:
> From: Denis Mukhin <dmukhin@xxxxxxxx> 
> 
> Use the new .config manipulation tool to toggle CONFIG_DEBUG in the
> Xen automation build script.
> 
> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> ---
>  automation/scripts/build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/scripts/build b/automation/scripts/build
> index 7a81d229decd..ee1127c53dc5 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -27,7 +27,7 @@ else
>      # Start off with arch's defconfig
>      make -C xen defconfig
>  
> -    echo "CONFIG_DEBUG=${debug}" >> xen/.config
> +    xen/scripts/config --file xen/.config -${debug} DEBUG

I'd suggest to add:

debug="${debug:-n}"

before calling xen/scripts/config to avoid errors in case debug is not
set

I could make the change on commit if you are OK with it


>      if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
>          echo "${EXTRA_XEN_CONFIG}" >> xen/.config
> -- 
> 2.52.0
> 



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.