[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] symbols: don't omit "end" symbols upon mixed code / data aliases
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 21 Jan 2026 18:16:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLbjfQE4Klx8uy2BarYQguK2zlMlRWrgXo0OPhjiZo4=; b=V83xloAjqhcI87Mv/JABp/mo3WUDfV3GrcrNnhg6WFQE2qpjvXEAmnIrSUZEOcaOEpuPbhYsohlhvhupMlsShcCniMJRlW3CnxyhyjwaNRnI+FZdYBdqGK3jUhUU3qEMblTdI9n4FR6J9lw7Ci1pqZ8hEpq6rGKyewaJChzZo/E59fDeXY7UVaPyWJuLwlXmQzlzT9dFIwwTXfhH0T3efjgIZc5ZSJghsHUe8p+ilYBKDBLaiKvRl0TrbnmrPCUC/0/941bwjVTiVhGSWP59adVQsVwtjhvqYkwpH7zN+A3SCwsXEE02a9wGx4e4/iXErx7WGjGZAOoxntyk6PHgmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zFpTqrYhsdbUQ9QB0upGA4uwLJCzEyim0Fu3PDvDHc6iKCMurnDkkCKvesUDoJDf6vJ341Oqspi+mDC+zc7vixPUGwNjUCxCPYPopV4M80MQ49KcmcjEfNBSctzt/aMwpEcEcksfU8VYhmk9y6LFIfMeN5iT8xpUM/JOEFaLKOqPE4qXT5YyOF+5EYxV8cKQ/AL4vxc/n6nDsRCKGg/CuNYtwhdPJMQMiSz+lsSMn37UBoZgQfxJKRDDzoHWREfy0CBugwWwhSecleEgwhjaKGHVp3OeCG4WCtKG24p1YDY1yK92WgYYDtS0BXkXmEiugkGkR4hV69l74e9HKWum4g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 21 Jan 2026 17:16:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jan 21, 2026 at 04:26:03PM +0100, Jan Beulich wrote:
> At the example of _sinitext - that symbol has four aliases on x86:
> __init_begin, __2M_init_start, __2M_rodata_end, and whatever the first
> function in .init.text. With the GNU toolchain all of them are marked
> 'T' or 't'. With Clang/LLVM, however, some are marked 'r'. Since, to
> save space, we want fake "end" symbols only for text, right now
> want_symbol_end() has a respective check. That is getting in the way,
> however, when the final of those symbols is 'r'. Remove the check and
> instead zap the size for anything that is non-code.
>
> Fixes: 6eede548df21 ('symbols: avoid emitting "end" symbols for data items')
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Roger, just fyi that I think that this change would mask the other issue
> that you reported, without actually adressing the underlying problem.
> Hence both changes will be wanted.
Yes, it does indeed mask the other issue.
Thanks, Roger.
|
