[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/8] x86/HPET: avoid indirect call to event handler
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 21 Jan 2026 17:19:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MrL40zoKsUTP6RSqiAVWjE+F74fL8LTYeUMQC72YRIc=; b=qFK1CuskYXei8x6dXY7JhOEHBwTHq9Agen2/36Ye1DpPoP2fwVIb8DSJQ17w64pI0RxrZpUhE+sbEX/648zQQMdgynFB66rxtzLfODjzXyLTEbVDT+/y9YptSlU0vfPEDqkqd7/vIWT3ftjsHrhQVAfd6v4qaxMlMTzYeYCwLVY7TOge4RX6BGHynU9nxKwCTxNFUst3T5zIKeLvAx8RK3VYhjaJjIuxAzEAmL544eRHLWF3qD8xuVj+naDCBdLsismKP+eYFKzxul2C+nj1kX63lSHvlx5XilohcTt5cZ6zhnt/p3qc3SenF+tVOW0LvXRYxZeaToTGiTqVR8wr5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z2Fy1zKuG/2+AGVzeP6hyvY2W5AT5tefTATAlwQdJZOHOxsLqLNdE1MQWYbEFmplsoi49PNtB1LZbblBrkCRYdxJATad85I3shOl5KRDVLi7dQDu6x+6o5EumIdNK6qaqbutOiPRd6Mx25rzVZ4u7P2RLCWoDMbLNlYSSLffx5KdHPSktXJK8YJCQuoipcUlv+kY881cf1vjWKIGUU2hLi/I19YfLj3SUcBVnfeocxPPNysd0qPbFlUGBjFYhwuITN7IMagoJ2ac3Nfp1j6O+4xNN4UZMQNgA77gATGztuZiZezcRZV3jmZojk1Nyfg0GC98IDV+DPpOrShm4aCNHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Wed, 21 Jan 2026 16:19:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Nov 17, 2025 at 03:37:04PM +0100, Jan Beulich wrote:
> It's only ever handle_hpet_broadcast() that's used. While we now don't
> enable IRQs right away, still play safe and convert the function pointer
> to a boolean, to make sure no calls occur too early.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> v2: Re-base over changes earlier in the series.
>
> --- a/xen/arch/x86/hpet.c
> +++ b/xen/arch/x86/hpet.c
> @@ -40,7 +40,7 @@ struct hpet_event_channel
> s_time_t next_event;
> cpumask_var_t cpumask;
> spinlock_t lock;
> - void (*event_handler)(struct hpet_event_channel *ch);
> + bool event_handler;
It would be nice to also get rid of this field, but I don't see any
other input that we could use to ensure the channel is ready to
receive interrupts.
Thanks, Roger.
|
