[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/svm: Add infrastructure for Bus Lock Threshold
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Wed, 21 Jan 2026 16:10:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9c5l+oGHnTXRL1LappdvbRkqqUgTw/8u1ICx4VqNYU=; b=jdRpv6GxnFPc+gjN2LigS/dQ6Qo0w8IPcwM6FNNPEB0O5F6gsmuVSHZJn85H7jn6Ypbrohlc24r9VCHCacPjAGjnbap9C6kxjRl+8GY02JiAc3dg0dYXsV9N+bFjYNgWhHVRKZmjvLIZseS4ej3mYWphkg3awsGx5AMVphE33hiFuhb7xhfI4yT4PGASoWjGiy2orR4YPwTh0Zzh+pNrEJpsb0Qdh2UTC1y6tgBXbRgb8ps3dBrUZO61f2t1v2sOqxj+CCqnfvscXkBNaEO6V9SB65yXIx9RFksAAG18KsRNstRE8IggYQ9jLkfC1DKMF+nQ+bq14AXpXDnKHuZmtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iyr+U0S1klq0P0K9s2y60wn8dUsDuoEXlRs4Q0dGBqA8mp8plQP5fNC0NrUHUaPCQsejzdbvkDvwhzu8wBM9tiRegVsAELhhPdpSjKkOydLcQn4+G9CAafnL/o3G5JJ04uDzdMsMsVFEmuwHWQ97eQfN3BIxNbPQlfLcgw7K97z/HG57Gv2L6mKOl2cThm0FIkmw7BWrmBpA4KppLH2UkUEc4kojSpF+AkNOh8s3+wc4dSMWbNRQoEOk25QINaa2NeuYumIv6D8GqrwwZ/x0jUaOz8gcuR1qAMStJ98u7TTQHh86veI7bC7mduhuE6cuORpIR0S42OF42VyOYqWK7g==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Wed, 21 Jan 2026 15:10:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed Jan 21, 2026 at 2:07 PM CET, Jan Beulich wrote:
> On 21.01.2026 13:40, Alejandro Vallejo wrote:
>> On Tue Jan 20, 2026 at 2:30 PM CET, Jan Beulich wrote:
>>> On 20.01.2026 14:19, Teddy Astie wrote:
>>>> Le 20/01/2026 à 10:56, Alejandro Vallejo a écrit :
>>>>> --- a/xen/arch/x86/hvm/svm/vmcb.h
>>>>> +++ b/xen/arch/x86/hvm/svm/vmcb.h
>>>>> @@ -65,6 +65,11 @@ enum GenericIntercept2bits
>>>>> GENERAL2_INTERCEPT_RDPRU = 1 << 14,
>>>>> };
>>>>>
>>>>> +/* general 2 intercepts */
>>>>
>>>> nit, you want to says general 3 intercepts
>>>
>>> And then, further nit, also get comment style right.
>>
>> What do you mean by comment style? it's a /* ... */ oneliner that matches
>> what the other general intercepts say. What am I missing?
>
> Quote from ./CODING_STYLE:
>
> "Multi-word comments should begin with a capital letter."
>
> Jan
Ack. Though also from CODING_STYLE:
"In general you should copy the style of the surrounding code."
and intercept groups 1 and 2 also start in lowercase. I'll correct both as well.
Cheers,
Alejandro
|
