[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/svm: Add infrastructure for Bus Lock Threshold


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
  • Date: Wed, 21 Jan 2026 13:40:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KDTbiEe+7vOD9nVnUGjI676FssFr+cbGLwlghSkzKGE=; b=U36/n7M0VPRs8mo1qz5PmSeNRriHuweOg3E1vjCTxlMH8san/qDCC5JHivj8ysqE1jmXn4sAO87HbP2LNtZhmlMBkxHBI41ybxEd29BncgJKMNumzRlFaymCoGL7CBKFR+k+fAngY/JHrpsG21jP8jbsuXdVR0c6bPMwokJyyzeIY8xPg5uz1Zb8XneY+D5947JXdcYoj5rIxTfNZjqdP3gE33wnJoblZ2Kr2ngdm/KSemlbE6kD9VGcqTCvsQNYMaZWNUtKCTmpNv/8lPNPJ9F8rZ/XwLI01sJCJCip8cZsYZZw3l1mq7ccA7rw+WN7r8DTiVylpQwgp68aV51rVA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kq+nk7Dln4/a8KblEwSl5xVkI+scHN01i3Wx6rFbjcB5yt3jpWXxw62JqEt+56su+UqXJLyV4R/I95v6+oRIKxZLihm8LNYuEoqtYoQWB4tkMmC72WJB1jdDrTt0PhgfJQrumhDCTaqALJEemNg+5xdaT27QsvtknIpuw/Grzr0+Z0ZuJ5TicpacyeXFS6Z8HMbcTZ0MbQUGPZ3poXmst0YC6LwRWS/mZOJcmWlvzJtnrSBsZi2z2diHLGDofT9/u8iBx+oB2qOQPSFVcFPbxenGh9Q93xJTdELwFST7OPFskaHW76xmzxWL3khVLefqgeDzWMBESoWH3e9RJJ4DAg==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 21 Jan 2026 12:41:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue Jan 20, 2026 at 2:30 PM CET, Jan Beulich wrote:
> On 20.01.2026 14:19, Teddy Astie wrote:
>> Le 20/01/2026 à 10:56, Alejandro Vallejo a écrit :
>>> --- a/xen/arch/x86/hvm/svm/vmcb.h
>>> +++ b/xen/arch/x86/hvm/svm/vmcb.h
>>> @@ -65,6 +65,11 @@ enum GenericIntercept2bits
>>>       GENERAL2_INTERCEPT_RDPRU   = 1 << 14,
>>>   };
>>>   
>>> +/* general 2 intercepts */
>> 
>> nit, you want to says general 3 intercepts
>
> And then, further nit, also get comment style right.
>
> Jan

What do you mean by comment style? it's a /* ... */ oneliner that matches
what the other general intercepts say. What am I missing?

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.