Re: [PATCH v1] xen: move vcpu_kick() declaration to common header

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 11/28/25 2:21 PM, Andrew Cooper wrote:
> On 28/11/2025 11:58 am, Jan Beulich wrote:
> > On 28.11.2025 12:38, Oleksii Kurochko wrote:
> > > The vcpu_kick() declaration is duplicated across multiple
> > > architecture-specific event.h headers (ARM, x86, PPC).
> > >
> > > Remove the redundant declarations and move vcpu_kick() into
> > > the common xen/include/xen/event.h header.
> > >
> > > Drop the definition of vcpu_kick() from ppc/include/asm/event.h,
> > > as it is already provided in ppc/stubs.c.
> > >
> > > Include <xen/event.h> instead of <asm/event.h> in places where
> > > vcpu_kick() is used, since its declaration now resides in
> > > <xen/event.h>.
> > Centralizing is of course good. Question is whether xen/event.h is a good
> > home for the decl. Generally related decls live in xen/sched.h. There was,
> > however, a vague plan to try to split that up some. Others, REST
> > maintainers in particular: Thoughts?
> +1 to centralising.  I'd suggest xen/sched.h too.
I will move to xen/sched.h. It will be even better as the patch will be cleaner
as <xen/sched.h> is mostly already included in the changed files in this patch.

Thanks.

~ Oleksii