[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] xen: move vcpu_kick() declaration to common header
- To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Nov 2025 13:21:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N2QEGf+zrHIxYID8CQKtWOgFrzfF3sHiE1bAHH/jRE0=; b=pHZKpa5QyoAyvFh+klaIsGYAqW+ak05yVQlbfiIH9TFY37J0OSqCaCrLny1/HUmyvXOTj5vU6PQGke/NxzWqPMYTWidw+aLJNwF58R7iv15e3ZPJ1Wo2gSUS8Hlc1skZJyRohJaT0O0cl2gJonc1HGGlhOfA3p/1a5RC0FGYthAR68hxT6+cSSlyQcJGchXmzIyFRRIPfv+SI+YwsLDia1lyD/79n8cBUBOqIW3pWKiy7eoZ08kLiJdPr1h0/JI6y7doSN68GpSOvjagqLJzmBc0GPLF30tTM6ZPOqCN9eUPLglblku6qUOGEE7ag+0FVT5JpIe/qtkn/JCAGEM64w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ySx50DlD6HRMenEKARInUbTKQUiGHC3zcdNfos0UBmKH2xJPMR6QE3s1c4RHVVHDwkFc7OrjWcOWnWFHcLhQ/c8iaoiNG5XpC4S298X6/+pFcBqjj1Dwk8G3DQTuYvBT/e+rvDlK1kgohoXayBdluhhDd35Px3+TV0mzSYU07oHTMS88MUjUPBjHvWL1hRCIGBvGOMiB3vEnlnDEPGFeLY1HbUeUPRxmZ/y69mBJVPPnfPEDEIiIc55RhEZADpuncadO1kAOifGtQKV7LjZdLJ/X6LOXWay8tkLD1sDvQnrZfL2gKzsDt0eW5dT/unTZRQucArYheflzzDr/QL6gnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: andrew.cooper3@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 28 Nov 2025 13:21:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/11/2025 11:58 am, Jan Beulich wrote:
> On 28.11.2025 12:38, Oleksii Kurochko wrote:
>> The vcpu_kick() declaration is duplicated across multiple
>> architecture-specific event.h headers (ARM, x86, PPC).
>>
>> Remove the redundant declarations and move vcpu_kick() into
>> the common xen/include/xen/event.h header.
>>
>> Drop the definition of vcpu_kick() from ppc/include/asm/event.h,
>> as it is already provided in ppc/stubs.c.
>>
>> Include <xen/event.h> instead of <asm/event.h> in places where
>> vcpu_kick() is used, since its declaration now resides in
>> <xen/event.h>.
> Centralizing is of course good. Question is whether xen/event.h is a good
> home for the decl. Generally related decls live in xen/sched.h. There was,
> however, a vague plan to try to split that up some. Others, REST
> maintainers in particular: Thoughts?
+1 to centralising. I'd suggest xen/sched.h too.
~Andrew
|
