[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v5] x86: make Viridian support optional
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
- Date: Tue, 28 Oct 2025 22:17:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rsjvXvARxaGXfVSFISr6mbzt/YqfM+Vx9vWaY02EJk8=; b=iAvNBOpKf9zBW5v9nuA3kIO8TZdz69/dDAEm26YvNu0C+b65teQPEZJy0KGoRsS4rK65NbRcoM1nnUd8XZGuDqg34AkJVByLymZXL2fmfgslxEPUlgePRWLnDQpFtUQEnSdQ7FVBDN/ZMlbcZifZYMCiG+QuZGW3fKKIJL2TWzuBPAV+pxORC7O9NPhfI/wutE43XMoC2oYcuqtRaUjr9VVncmHUeNcASe2DYkKSY4MLYd8HWgi/4D+Ui4W1WjkGtlHGkLrdMIvHplK5MiA4iYVzi3ebgBQRGu5771AC+ckQQihx9qbCOjfGsyjAAI4+AjW7DmNSwPKB+9U1ObkV4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PAM0GP6TieCgzW6751OI+IoAJ0ECPBBRoJM+g8VRoa6c5PsKZozGbNNb+Y5zCqBpLolZyV7ptz18RR7QSiWzSES1VslBlkpHa7dMtRP5al/yk4JWtltg0hkzU26cu1s8oCn1KFIIPRkeloICPHFCA/KX0H+s5aKR21YelJWi6Y7sm4e587BQqkJ/lyLUGtsy8+7eGZ020PiBGhG6x5FyWeM31tVXRoaatfea7+81UjIbIPSZS99So5yhdUY4DZEccWYU1RhW/kGNfghOKC4aGSuCBauQDhudufxBceo/RGF7+oDQpGpsJ3qh8VYL/rE+c8ZFNtXVGncc9lzyiF03dA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Tue, 28 Oct 2025 20:18:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jason,
On 24.10.25 21:55, Jason Andryuk wrote:
On 2025-10-23 11:18, Grygorii Strashko wrote:
From: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Add config option VIRIDIAN that covers viridian code within HVM.
Calls to viridian functions guarded by is_viridian_domain() and related macros.
Having this option may be beneficial by reducing code footprint for systems
that are not using Hyper-V.
[grygorii_strashko@xxxxxxxx: fixed NULL pointer deref in
viridian_save_domain_ctxt(); stub viridian_vcpu/domain_init/deinit()]
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
diff --git a/xen/arch/x86/hvm/viridian/viridian.c
b/xen/arch/x86/hvm/viridian/viridian.c
index f79cffcb3767..b935803700fd 100644
--- a/xen/arch/x86/hvm/viridian/viridian.c
+++ b/xen/arch/x86/hvm/viridian/viridian.c
@@ -1153,6 +1156,9 @@ static int cf_check viridian_load_vcpu_ctxt(
struct vcpu *v;
struct hvm_viridian_vcpu_context ctxt;
+ if ( !is_viridian_domain(d) )
+ return -EILSEQ;
Given:
#define is_viridian_domain(d) \
(IS_ENABLED(CONFIG_VIRIDIAN) && \
is_hvm_domain(d) && (viridian_feature_mask(d) & HVMPV_base_freq))
CONFIG_VIRIDIAN=n is okay because of the IS_ENABLED.
For CONFIG_VIRIDIAN=y && a viridian domain, is HVM_PARAM_VIRIDIAN guaranteed to be loaded
before viridian_load_vcpu_ctxt() is called, so that HVMPV_base_freq can be checked
properly? I don't know, but it seems a little fragile if this relies on implicit
ordering. Maybe just do:
if ( !IS_ENABLED(CONFIG_VIRIDIAN) )
return -EILSEQ;
?
Should it be done the same way for viridian_load_domain_ctxt() also?
Everything else looks good.
Thanks,
Jason
+
if ( vcpuid >= d->max_vcpus || (v = d->vcpu[vcpuid]) == NULL )
{
dprintk(XENLOG_G_ERR, "HVM restore: dom%d has no vcpu%u\n",
--
Best regards,
-grygorii
|
