[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v5] x86: make Viridian support optional
- To: Grygorii Strashko <grygorii_strashko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 24 Oct 2025 14:55:35 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ibERSIjWiw3lqYXNt4HxNx1HOXMAhQLE2KkAnV79nkg=; b=DG+txKAuaRE+vb6tghO3xPTvchBnHeeAFJ4aD77nPQ9IZdRLUVKVWB4Ww5P36K1qgUn15LRcVbdiLG1zWJceh+OHJ2+DG8rNN1wzVkH4hlaBvilNZHIEjbDEfzWefje3L5xAdSkTFOV7KopOkwQALuwf2uJqegF5ZjVGe4OpzwBtHxqYiLHWSErdCawaqLFK7vrmq+mgvPAaWfySbTXF7rly7n1qGOIYGe61jlHhH1Cvjqk6hHjEwFz1RExIEnHwcSNo7mvbHQ63AE9OWjj4xD2Dqe/gX7nDyFZHMMaeKedThiC3JubYb6gepoBjI4yUDq0VfO2Gs+McuSpEBsdDgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OrhqbMBM48xO4eCFXG8EIpUIQNq3+QiZbdXdltBuVLWIfNMbJq7/o7uRn2E3XVQtUhSq0BZep2AhDED56/iQa6e+3PvPMKKefwJor/5Or0yqztmkqhmZbNw8xtXWfc9aYWdTsvGjxkcMXt4UmW7Kbq6pk0+ZHQBr478bsew+gN7fKveljuqYt1l5DQjKb8CH4Qjyv5I1G8UWH8HWS6zS1BmEV0UhHGJCo8PgYcsIIEttS4h9TveHupXNN7ZDk/ef5zGjLaqg3hs+FD/jswk5W+Cws03fetOl9aOOg1UOjrQVTlJN4kOlteStAmV1aFzc0mrbovn63QOtujI7rGpqFQ==
- Cc: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Fri, 24 Oct 2025 18:55:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-10-23 11:18, Grygorii Strashko wrote:
From: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Add config option VIRIDIAN that covers viridian code within HVM.
Calls to viridian functions guarded by is_viridian_domain() and related macros.
Having this option may be beneficial by reducing code footprint for systems
that are not using Hyper-V.
[grygorii_strashko@xxxxxxxx: fixed NULL pointer deref in
viridian_save_domain_ctxt(); stub viridian_vcpu/domain_init/deinit()]
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Signed-off-by: Grygorii Strashko <grygorii_strashko@xxxxxxxx>
---
diff --git a/xen/arch/x86/hvm/viridian/viridian.c
b/xen/arch/x86/hvm/viridian/viridian.c
index f79cffcb3767..b935803700fd 100644
--- a/xen/arch/x86/hvm/viridian/viridian.c
+++ b/xen/arch/x86/hvm/viridian/viridian.c
@@ -1153,6 +1156,9 @@ static int cf_check viridian_load_vcpu_ctxt(
struct vcpu *v;
struct hvm_viridian_vcpu_context ctxt;
+ if ( !is_viridian_domain(d) )
+ return -EILSEQ;
Given:
#define is_viridian_domain(d) \
(IS_ENABLED(CONFIG_VIRIDIAN) && \
is_hvm_domain(d) && (viridian_feature_mask(d) & HVMPV_base_freq))
CONFIG_VIRIDIAN=n is okay because of the IS_ENABLED.
For CONFIG_VIRIDIAN=y && a viridian domain, is HVM_PARAM_VIRIDIAN
guaranteed to be loaded before viridian_load_vcpu_ctxt() is called, so
that HVMPV_base_freq can be checked properly? I don't know, but it
seems a little fragile if this relies on implicit ordering. Maybe just do:
if ( !IS_ENABLED(CONFIG_VIRIDIAN) )
return -EILSEQ;
?
Everything else looks good.
Thanks,
Jason
+
if ( vcpuid >= d->max_vcpus || (v = d->vcpu[vcpuid]) == NULL )
{
dprintk(XENLOG_G_ERR, "HVM restore: dom%d has no vcpu%u\n",
|
