[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 for-4.21 1/1] tools/libs/light: fix BAR memory address truncation


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jiqian Chen <Jiqian.Chen@xxxxxxx>
  • Date: Thu, 23 Oct 2025 10:31:28 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jzzlbktxq2hou8uT/J3+lh+jDqmABPI0cz1BM5u8Ppc=; b=FYFSgsjYXGFNJD+kPpgPp0ej7jWTWhnH8nNJ6uJIj9iXJGuc1Tp21B+9nFgBaTDyZ41Lzk7LTbeiTb94w1qc34Qtebfv1zCF0LMzQyVjkorIICTgSHKIReq/+GkrgcNoumiorBxV95B5uqDeMouehzO53ARLI6p9WiNxw0nSz1i6KWWrwn2DB6CbhEipRNtzEwRXaPu4nuMQSx3rjj5TigTctpe9SfSpF/42//1fX8MKq4nc9uzx0nnlRWDQcog0GLRBOErr7krQ3iOxlMpXYy/e7efmP//QkCZgGStuSMhcUkuOBvADU3uJa8yFM0BBqc//Mq5bKnjkZEdabk4rjA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ciLZh4e4K/7BrdkYhML1CnuRNtAD3opaOUJJrtIs4lYiQQBbU24l2LzE4QVkLwxbTLcrMoYY3NtTxMBmL11Wg087A/v6R6oUL1R3e3EAur50bgO06sHbPfMrlHPCIdy+EoVKnRmdTd4pflGWkbY488EDYs0WZSoq0RxOZ9cj8/HP7XBHbw1qffmJRfSLiSAns0JPA81vngsNUZ5V3lxvZ5k2fRLzKU60We470LJMzGUhn+9trd9gA6eFVvUrGxtyYi7xdHXbwLbmGUtzQP8VI9zFGhr5QVvxsrlBwbIYNvvBelZDpzon4KzY884TBhMMbm2h1KyfZL7n40X2jT/jFQ==
  • Cc: Huang Rui <ray.huang@xxxxxxx>, Jiqian Chen <Jiqian.Chen@xxxxxxx>, "Oleksii Kurochko" <oleksii.kurochko@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Thu, 23 Oct 2025 02:32:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

64-bit BAR memory address is truncated when removing a passthrough
pci device from guest since it uses "unsigned int".

So, change to use 64-bit type to fix this problem.

Fixes: b0a1af61678b ("libxenlight: implement pci passthrough")
Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
---
cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
cc: Juergen Gross <jgross@xxxxxxxx>
---
v2->v3 changes:
* Split a line that is too long.
* No functional chianges.
* Add Juergen's Reviewed-by.

v1->v2 changes:
* Change to use uint64_t instead of unsigned long long and change
  corresponding fscanf and LOGED parameters.
---
 tools/libs/light/libxl_pci.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
index 2ea2caeb6624..49d272d0de65 100644
--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -2001,7 +2001,8 @@ static void pci_remove_detached(libxl__egc *egc,
 {
     STATE_AO_GC(prs->aodev->ao);
     libxl_ctx *ctx = libxl__gc_owner(gc);
-    unsigned int start = 0, end = 0, flags = 0, size = 0, irq = 0;
+    uint64_t start = 0, end = 0, flags = 0, size = 0;
+    unsigned int irq = 0;
     int i, stubdomid = 0;
     const char *sysfs_path;
     FILE *f;
@@ -2031,7 +2032,8 @@ static void pci_remove_detached(libxl__egc *egc,
     }
 
     for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) {
-        if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) != 3)
+        if (fscanf(f, "0x%"SCNx64" 0x%"SCNx64" 0x%"SCNx64"\n",
+                   &start, &end, &flags) != 3)
             continue;
         size = end - start + 1;
         if (start) {
@@ -2040,7 +2042,7 @@ static void pci_remove_detached(libxl__egc *egc,
                                                  size, 0);
                 if (rc < 0)
                     LOGED(ERROR, domid,
-                          "xc_domain_ioport_permission error 0x%x/0x%x",
+                          "xc_domain_ioport_permission error 
%#"PRIx64"/%#"PRIx64,
                           start,
                           size);
             } else {
@@ -2050,7 +2052,7 @@ static void pci_remove_detached(libxl__egc *egc,
                                                 0);
                 if (rc < 0)
                     LOGED(ERROR, domid,
-                          "xc_domain_iomem_permission error 0x%x/0x%x",
+                          "xc_domain_iomem_permission error 
%#"PRIx64"/%#"PRIx64,
                           start,
                           size);
             }
-- 
2.34.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.